server: prohibit more than MaxConcurrentStreams handlers from running at once (#6703) #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Oct 11, 2023
| if maxStreams == 0 { | ||
| maxStreams = math.MaxUint32 | ||
| } else { | ||
| if config.MaxStreams != math.MaxUint32 { |
There was a problem hiding this comment.
Does it mean that it will NOT take effect any more if applications set MaxConcurrentStreams as math.MaxUint32?
Note the default value set by etcd is math.MaxUint32, reference:
There was a problem hiding this comment.
It seems OK, since the default maxConcurrentStreams is math.MaxUint32
bboreham
reviewed
Oct 18, 2023
| // concurrent calls to acquire, but also note that with synchronous calls to | ||
| // acquire, as our system does, n will never be less than -1. There are | ||
| // fairness issues (queuing) to consider if this was to be generalized. | ||
| if atomic.AddInt64(&q.n, -1) <= 0 { |
There was a problem hiding this comment.
Suspect this -1 should be 1.
Spotted by @colega
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: